Viral vectors and methods of making such vectors are described that preferentially kill neoplastic but not normal cells, the preferred vector being an adenovirus that has the endogenous promoters in the E1A and/or E4 regions substituted with a tumor specific promoter which is preferably E2F responsive.